Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter input when using Terminal.app #3392

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

rogeliog
Copy link
Contributor

This issue got introduced by #3327

Summary

The position of the cursor is wrong in some terminals like Terminal.app, but not in other terminals that do support clearScreen

Test plan

Here is the before and after
filters-issue

@codecov-io
Copy link

Codecov Report

Merging #3392 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3392      +/-   ##
==========================================
+ Coverage    64.2%   64.23%   +0.03%     
==========================================
  Files         176      176              
  Lines        6546     6552       +6     
  Branches        4        4              
==========================================
+ Hits         4203     4209       +6     
  Misses       2342     2342              
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/watch.js 76.29% <ø> (ø) ⬆️
packages/jest-cli/src/TestNamePatternPrompt.js 94.82% <100%> (+0.28%) ⬆️
packages/jest-cli/src/TestPathPatternPrompt.js 98.24% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c2eff...ba04fb8. Read the comment docs.

@cpojer cpojer merged commit dd937ae into jestjs:master Apr 27, 2017
@cpojer
Copy link
Member

cpojer commented Apr 27, 2017

I trust you that this makes sense.

5399f8caf0a80d8c9eb95c941e10d3eae4f3242712bdbde58d6deac99babe7ec

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants