Add Localization for Jest Docs Website #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
@ericnakagawa let me know when this is ready to merge :) |
Codecov Report
@@ Coverage Diff @@
## master #3416 +/- ##
=======================================
Coverage 64.02% 64.02%
=======================================
Files 177 177
Lines 6580 6580
Branches 5 5
=======================================
Hits 4213 4213
Misses 2365 2365
Partials 2 2Continue to review full report at Codecov.
|
* Adds a link to CrowdIn project from language drop down * Adds comments to generated files * Modify Circle CI to manually download crowdin cli * Doc build process only renders pages that are enabled in languages.js * Added a favicon.ico * Merging TutorialAsync.md Adding Bosnian, enabling Espanol Using ENV variables
|
Alright, let's give this a go. |
ericnakagawa
added a commit
that referenced
this pull request
May 2, 2017
This reverts commit 62d29f2.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Adds a link to CrowdIn project from language drop down * Adds comments to generated files * Modify Circle CI to manually download crowdin cli * Doc build process only renders pages that are enabled in languages.js * Added a favicon.ico * Merging TutorialAsync.md Adding Bosnian, enabling Espanol Using ENV variables
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Localization support for Jest.
Test plan
This PR includes changes to circle.yml that tests the website build process.
Once tests pass, the lines will be removed, and the test lines will be removed.
I was able to login to an SSH CI session and simulate the CrowdIn upload, download, and website build steps.