lint .eslintrc.js #3938
Merged
lint .eslintrc.js #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaronabramov
commented
Jun 29, 2017
aaronabramov
commented
Codecov Report
@@ Coverage Diff @@
## master #3938 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 196 196
Lines 6758 6758
Branches 6 6
=======================================
Hits 3924 3924
Misses 2831 2831
Partials 3 3Continue to review full report at Codecov.
|
SimenB
reviewed
Jun 29, 2017
| // This has to be disabled until all type and module imports are combined | ||
| // https://github.com/benmosher/eslint-plugin-import/issues/645 | ||
| 'import/order': 0, | ||
| // These has to be disabled until the whole code base is converted to ESM |
There was a problem hiding this comment.
this is off from where it should be now.
There was a problem hiding this comment.
sorry, missed that one :(
#3939
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.