Rotate workers when they are all idling #4921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all workers are idling (i.e. they are not doing any work), worker
1
keeps getting all the jobs. This is due to thefor
loop that pushes sequentially all jobs from worker0
to workern-1
. Unless explicitly wanted (because of acomputeWorkerKey
present), this is usually not a desired behavior.Adding an offset and a modulo should do the trick. When all workers are busy, the logic is not affected, though; the first available worker will still pick the job.