Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "jest-runtime: move babel-core to peer dependenies (#4557)" #4923

Merged
merged 2 commits into from
Nov 20, 2017
Merged

Revert "jest-runtime: move babel-core to peer dependenies (#4557)" #4923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afbc7d9
Revert "jest-runtime: move babel-core to peer dependenies (#4557)"
SimenB Nov 20, 2017
ef23830
Update changelog
SimenB Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
([#4599](https://github.com/facebook/jest/pull/4599))
* `[jest-runtime]` Fix manual user mocks not working with custom resolver
([#4489](https://github.com/facebook/jest/pull/4489))
* `[jest-runtime]` Move `babel-core` to peer dependencies so it works with Babel
7 ([#4557](https://github.com/facebook/jest/pull/4557))
* `[jest-util]` Fix `runOnlyPendingTimers` for `setTimeout` inside
`setImmediate` ([#4608](https://github.com/facebook/jest/pull/4608))
* `[jest-message-util]` Always remove node internals from stacktraces
Expand Down
5 changes: 1 addition & 4 deletions packages/jest-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"license": "MIT",
"main": "build/index.js",
"dependencies": {
"babel-core": "^6.0.0",
"babel-jest": "^21.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to decouple this, right? I haven't dug into how this works, yet...

"babel-plugin-istanbul": "^4.1.5",
"chalk": "^2.0.1",
Expand All @@ -26,13 +27,9 @@
"yargs": "^9.0.0"
},
"devDependencies": {
"babel-core": "^6.0.0",
"jest-environment-jsdom": "^21.2.1",
"jest-environment-node": "^21.2.1"
},
"peerDependencies": {
"babel-core": "^6.0.0 || ^7.0.0-alpha || ^7.0.0-beta || ^7.0.0"
},
"bin": {
"jest-runtime": "./bin/jest-runtime.js"
}
Expand Down