Make Jest work with latest react-native on node 9. #5050
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5050 +/- ##
=======================================
Coverage 60.74% 60.74%
=======================================
Files 198 198
Lines 6605 6605
Branches 4 4
=======================================
Hits 4012 4012
Misses 2593 2593Continue to review full report at Codecov.
|
|
Is this the same issue as nodejs/node#17040? So he just has to upgrade to react 16? |
| @@ -6,8 +6,8 @@ | |||
| "test": "jest" | |||
| }, | |||
| "dependencies": { | |||
| "react": "15.4.2", | |||
| "react-native": "^0.40.0" | |||
| "react": "16.2.0", | |||
There was a problem hiding this comment.
I get a peer dep warning when installing, is that ok?
warning " > react-native@0.51.0" has incorrect peer dependency "react@16.0.0".
There was a problem hiding this comment.
It works, so I'm fine with it.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Turns out we were still using RN 0.4 and React 15. I upgrade those + update the snapshots for the RN repo. The downside is that it now uses
RTCScrollViewto render. This is an RN thing and not a Jest thing and we can fix it later.Test plan
On Node.js 9, Jest will pass the RN test