-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use all --testPathPattern and <regexForTestFiles> args in testPathPattern #5066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5066 +/- ##
==========================================
- Coverage 60.76% 60.75% -0.01%
==========================================
Files 198 198
Lines 6603 6602 -1
Branches 4 4
==========================================
- Hits 4012 4011 -1
Misses 2591 2591
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup!
Thanks for contributing to Jest <3 |
Happy to see things move so quickly! Any suggestions on the next issue? I'm looking at Help Wanted. 😁 |
@seanpoulter help with getting open PRs over the line would be great 🙂 As well as hardening the codeframe merged yesterday (I'll create an issue for it) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR changes:
--testPathPattern
arg to match the multiple allowed values--testPathPattern
args are joined to form a valid regular expression--testPathPattern
args are joined with the default<regexForTestFiles>
argsThis closes #5037.
Test plan
Tests have been added to check the way the args are joined.
Evaluating the two test cases from #5037 also produce expected patterns: