-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update condition to avoid infinite recursion in Windows platform #5161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5161 +/- ##
==========================================
+ Coverage 60.64% 60.66% +0.01%
==========================================
Files 201 201
Lines 6695 6693 -2
Branches 4 4
==========================================
Hits 4060 4060
+ Misses 2634 2632 -2
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for this? We probably have one already, but skip it on windows
@SimenB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Thank you for sending a bug fix PR to Jest :) |
@cpojer It's my first PR in github, I'm glad to make Jest better 😄 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Related issue is #5141
Test plan
No additional test