Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update condition to avoid infinite recursion in Windows platform #5161

Merged
merged 3 commits into from
Dec 23, 2017
Merged

Update condition to avoid infinite recursion in Windows platform #5161

merged 3 commits into from
Dec 23, 2017

Conversation

Justin-ZS
Copy link
Contributor

Summary
Related issue is #5141

Test plan
No additional test

@codecov-io
Copy link

codecov-io commented Dec 22, 2017

Codecov Report

Merging #5161 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5161      +/-   ##
==========================================
+ Coverage   60.64%   60.66%   +0.01%     
==========================================
  Files         201      201              
  Lines        6695     6693       -2     
  Branches        4        4              
==========================================
  Hits         4060     4060              
+ Misses       2634     2632       -2     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/resolve_config_path.js 95.45% <100%> (ø) ⬆️
packages/jest-cli/src/watch.js 74.82% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e879099...ac59fda. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this? We probably have one already, but skip it on windows

@Justin-ZS
Copy link
Contributor Author

@SimenB
It has some tests already and cover all the cases in function, but they are skipped on windows.
I remove theskipOnWindows since those tests run fine on windows.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@cpojer cpojer merged commit 5a37891 into jestjs:master Dec 23, 2017
@cpojer
Copy link
Member

cpojer commented Dec 23, 2017

Thank you for sending a bug fix PR to Jest :)

@Justin-ZS
Copy link
Contributor Author

Justin-ZS commented Dec 23, 2017

@cpojer It's my first PR in github, I'm glad to make Jest better 😄

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants