Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize file names: Fix file names in root #5500

Merged
merged 2 commits into from Feb 9, 2018
Merged

Standardize file names: Fix file names in root #5500

merged 2 commits into from Feb 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 9, 2018

Summary

Follows up @jamischarles work on #4969.

Details

  • ran git mv to rename files
  • used Atom's search and replace to replace all occurrences of a file renaming with the new filemname

Now files in root can follow standard FB practice:

- Files that primarily export types, objects or classes should use CapitalizedFileNames.js and should mirror what’s inside 1:1.
- Files that export a single function should have the function name with camelCase in it.
- Folder names should use dashes, unless they are special folders.

Test plan

Running yarn test passes. Let me know if something needs changing.

@codecov-io
Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #5500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5500   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files         213      213           
  Lines        7071     7071           
  Branches        3        3           
=======================================
  Hits         4361     4361           
  Misses       2709     2709           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/valid_config.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3942361...bac1af5. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI. Thanks for doing this!

@cpojer cpojer merged commit 7c398db into jestjs:master Feb 9, 2018
@cpojer
Copy link
Member

cpojer commented Feb 9, 2018

Yeah!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants