Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize finding top frame in formatPaths #5557

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

Connormiha
Copy link
Contributor

Summary

Optimized finding top frame.

  • Used only 1 loop instead of 6 loops.
  • Break loop after found first matched item.

Test plan

@codecov-io
Copy link

Codecov Report

Merging #5557 into master will increase coverage by <.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5557      +/-   ##
==========================================
+ Coverage    61.7%   61.71%   +<.01%     
==========================================
  Files         213      213              
  Lines        7150     7156       +6     
  Branches        4        3       -1     
==========================================
+ Hits         4412     4416       +4     
- Misses       2737     2739       +2     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-message-util/src/index.js 81.1% <81.81%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5fbd30...56e31c9. Read the comment docs.

@cpojer cpojer merged commit 1ee7df9 into jestjs:master Feb 14, 2018
@cpojer
Copy link
Member

cpojer commented Feb 14, 2018

Thanks for doing this!

jessecarfb pushed a commit to jessecarfb/jest that referenced this pull request Feb 14, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants