Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JestObjectAPI.md #5559

Merged
merged 2 commits into from
Feb 14, 2018
Merged

Update JestObjectAPI.md #5559

merged 2 commits into from
Feb 14, 2018

Conversation

shaneu
Copy link
Contributor

@shaneu shaneu commented Feb 14, 2018

small typo :)

Summary

Just a small typo, missing an 's'

Test plan

no test necessary

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Feb 14, 2018

Codecov Report

Merging #5559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5559   +/-   ##
======================================
  Coverage    61.7%   61.7%           
======================================
  Files         213     213           
  Lines        7150    7150           
  Branches        4       4           
======================================
  Hits         4412    4412           
  Misses       2737    2737           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5fbd30...75ea3e9. Read the comment docs.

@@ -158,7 +158,7 @@ as well as all the modules that it imports._

Modules that are mocked with `jest.mock` are mocked only for the file that calls
`jest.mock`. Another file that imports the module will get the original
implementation even if run after the test file that mocks the module.
implementation even if runs after the test file that mocks the module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shaneu, thanks for the fix

This seems wrong to me, did you mean to change this to:

even if it runs after the test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, I saw that run was missing an 's', totally missed that it was also missing 'it'! Yes, that's what I meant/

@SimenB SimenB merged commit 84e9789 into jestjs:master Feb 14, 2018
jessecarfb pushed a commit to jessecarfb/jest that referenced this pull request Feb 14, 2018
* Update JestObjectAPI.md

small typo :)

* Update JestObjectAPI.md
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants