Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TutorialReactNative.md #5567

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Update TutorialReactNative.md #5567

merged 1 commit into from
Feb 15, 2018

Conversation

Billy-
Copy link
Contributor

@Billy- Billy- commented Feb 14, 2018

Removes redundant import react-native
reactjs/react.dev#614

Removes redundant `import react-native`
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@rickhanlonii
Copy link
Member

@billy thanks for the contribution!

This seems like an important note, what's the rationale for removing it completely?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #5567 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5567   +/-   ##
=======================================
  Coverage   61.67%   61.67%           
=======================================
  Files         213      213           
  Lines        7160     7160           
  Branches        3        3           
=======================================
  Hits         4416     4416           
  Misses       2743     2743           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10276f9...f048e45. Read the comment docs.

@Billy-
Copy link
Contributor Author

Billy- commented Feb 14, 2018

@rickhanlonii

@billy thanks for the contribution!

This seems like an important note, what's the rationale for removing it completely?

According to Dan's comment on that issue I opened, it's outdated and not necessary anymore.

@cpojer cpojer merged commit b9b1f0d into jestjs:master Feb 15, 2018
@cpojer
Copy link
Member

cpojer commented Feb 15, 2018

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants