Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify check for -0 in printNumber #5581

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

Connormiha
Copy link
Contributor

Summary

Objest.is is the easiest way to compare 0 and -0. Also it doesn't need special check for NaN, because String work corrent.

Test plan

@codecov-io
Copy link

Codecov Report

Merging #5581 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5581      +/-   ##
==========================================
- Coverage   60.63%   60.61%   -0.02%     
==========================================
  Files         213      213              
  Lines        7311     7308       -3     
  Branches        3        4       +1     
==========================================
- Hits         4433     4430       -3     
  Misses       2877     2877              
  Partials        1        1
Impacted Files Coverage Δ
packages/pretty-format/src/index.js 96.37% <100%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966aab6...1a38e8e. Read the comment docs.

@cpojer cpojer merged commit 0285e63 into jestjs:master Feb 16, 2018
@cpojer
Copy link
Member

cpojer commented Feb 16, 2018

Nice!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants