Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore-cache issue on CircleCi #5688

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Fix restore-cache issue on CircleCi #5688

merged 1 commit into from
Feb 28, 2018

Conversation

peterdanis
Copy link
Contributor

@peterdanis peterdanis commented Feb 28, 2018

Summary

Should fix #5687 and fix #5526.

Test plan

  • put the CircleCi build to broken state
  • fix it

@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #5688 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5688   +/-   ##
=======================================
  Coverage   63.16%   63.16%           
=======================================
  Files         216      216           
  Lines        7913     7913           
  Branches        4        4           
=======================================
  Hits         4998     4998           
  Misses       2914     2914           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303c078...37e9015. Read the comment docs.

@peterdanis
Copy link
Contributor Author

PR is finished.

@peterdanis peterdanis changed the title [WIP] Fix restore-cache issue on CircleCi Fix restore-cache issue on CircleCi Feb 28, 2018
@thymikee
Copy link
Collaborator

Can you send some small updates, so the cache is actually read? Right I can see this
screen shot 2018-02-28 at 14 19 16

@peterdanis
Copy link
Contributor Author

peterdanis commented Feb 28, 2018

I rewrote previous commits by force pushing only the final commit. But please see the full history of build logs for this PR at https://circleci.com/gh/facebook/jest/tree/pull%2F5688.

  • first batch of builds is ok, because no cache exists
  • second batch is broken, because only the test-browser build job was allowed to save cache and rest was not able to restore it to /root/jest

First & second batch of this PR on picture:
image

The latest builds in this PR build log are using cache from fixed test-browser build job. For example test-node-8 build job #16414 is using cache from test-browser build job #16404:
image

@thymikee
Copy link
Collaborator

Ok, so the test-browser's docker image had different home dir set up and we need to adjust that. Makes sense 👍

@thymikee thymikee merged commit 608feac into jestjs:master Feb 28, 2018
@peterdanis peterdanis deleted the fix-circle-cache branch February 28, 2018 14:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleCi build - fails on restore-cache Investigate CircleCI cache failures
4 participants