Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expect): do not rely on 'instanceof RegExp' #5729

Merged
merged 3 commits into from
Mar 6, 2018
Merged

fix(expect): do not rely on 'instanceof RegExp' #5729

merged 3 commits into from
Mar 6, 2018

Commits on Mar 5, 2018

  1. fix(expect): do not rely on 'instanceof RegExp' 

    `instanceof RegExp` will not be true for RegExp objects created inside of a different NodeJS VM or Window.

This commit fixes this issue by checking for 'regexp.test' function instead.
    @niieani
    niieani committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    6de9773 View commit details
    Browse the repository at this point in the history

  2. chore(CHANGELOG): entry for instanceof RegExp fix

    @niieani
    niieani committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    ceba50c View commit details
    Browse the repository at this point in the history

  3. fix(expect): silence erroneous flow errors

    @niieani
    niieani committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    648c3d5 View commit details
    Browse the repository at this point in the history