-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sets project name if empty fixes #5597 #5862
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
5756129
sets project name if empty fixes #5597
50d9933
added to changelog
6036dfa
cr comments
be1cc18
removed unused import
6054f0b
fixed tests
feb9751
use inital options instead of project config
0bf6d8e
fix unintentional type change
paularmstrong 4f72619
fixed path string and deleted unneeded test files
b7c061f
Merge branch 'master' into set_project_name_if_empty
0713d0f
merged in master
65c64d9
updated snapshots and tests
a856fb1
removed updated snapshots put change under fixes
04b0bb6
Merge branch 'master' into set_project_name_if_empty
80d21e6
merged master
2f14830
Merge branch 'master' into set_project_name_if_empty
cbelsole 30fecea
Merge branch 'master' into set_project_name_if_empty
SimenB 54302cf
Merge remote-tracking branch 'origin' into set_project_name_if_empty
cbelsole be40277
Merge remote-tracking branch 'root/master' into set_project_name_if_e…
cbelsole 8c8761d
unique names across config and projects
cbelsole 78801aa
fixed changelog
cbelsole 9bbbd61
Update CHANGELOG.md
SimenB 61523b0
Merge branch 'master' into set_project_name_if_empty
SimenB 44aa91d
use Set
SimenB a370c21
use random uuid for assigning project name
thymikee 1ab0bac
remove unnecessary test
thymikee 691339f
fix lint
thymikee 6fcab16
add e2e test
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While running a repro again, I discovered this only happens when we run multiple workers, so added this test. It fails without
uuid
.