-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove assert message from stack #6061
Conversation
Codecov Report
@@ Coverage Diff @@
## 22.x #6061 +/- ##
==========================================
- Coverage 62.32% 62.31% -0.02%
==========================================
Files 216 216
Lines 7905 7907 +2
Branches 4 4
==========================================
Hits 4927 4927
- Misses 2977 2979 +2
Partials 1 1
Continue to review full report at Codecov.
|
I can do that, but I will need a couple of reminders tomorrow 😄 |
@SimenB |
Isn't 22.4.2 the latest? But yeah, just a patch release from the 22 branch (not from master as it contains breaking changes) |
jestjs/jest#6061 causes Jest to omit AssertionError messages in the test output. This means that without runner-jest converting AssertionErrors to regular Errors, Jest output now isn't very helpful at all.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
We've merged node 10 compat into master (#6055), but because we've landed breaking changes leading up to a v23, we cannot release it.
I think the changes to the message from the assert module (a diff view with swapped
+
and-
from what Jest uses) are large enough that it will confuse users of Jest, so we should make a patch release of Jest 22 with just the removal of that diff.In this PR, I've basically cherry picked #6055 on top of the 22.4.2 release commit. I've also setup a https://github.com/facebook/jest/tree/22.x branch which this can be merged to.
See this screenshot for example of the output this PR cleans up:
Test plan
Green CI.
node@10.0.0-rc.2
also passes with this change.