Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React to 16.3.2 #6092

Closed
wants to merge 1 commit into from
Closed

Upgrade React to 16.3.2 #6092

wants to merge 1 commit into from

Conversation

jkimbo
Copy link
Contributor

@jkimbo jkimbo commented Apr 29, 2018

Summary

To support the new forwardRef and Context api's in pretty-format the version of React that is used in tests needs to be updated.

Test plan

Ensure tests pass.

@codecov-io
Copy link

Codecov Report

Merging #6092 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6092   +/-   ##
======================================
  Coverage    64.1%   64.1%           
======================================
  Files         217     217           
  Lines        8335    8335           
  Branches        4       4           
======================================
  Hits         5343    5343           
  Misses       2991    2991           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9850275...7710689. Read the comment docs.

@thymikee
Copy link
Collaborator

FYI we plan to clean up how our internal deps are resolved by Yarn and your change is included in this PR: #6090. If it gets merged, this one becomes obsolete (I'll mark it so GitHub can do it automatically).

@jkimbo
Copy link
Contributor Author

jkimbo commented Apr 29, 2018

That's great thanks. I raised this PR only because I needed to upgrade react for this: #6093

@cpojer cpojer closed this in #6090 Apr 30, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants