Test with Node 10 on CI

[SimenB]

Summary

Node 10 is out, let's make sure we work. We should as #6055 is merged 🤞

Test plan

Green CI

[codecov-io]

Codecov Report

Merging #6097 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6097   +/-   ##
======================================
  Coverage    64.1%   64.1%           
======================================
  Files         217     217           
  Lines        8335    8335           
  Branches        4       3    -1     
======================================
  Hits         5343    5343           
  Misses       2991    2991           
  Partials        1       1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c75933...435ba90. Read the comment docs.

[thymikee]

How about replacing Node 9 with 10? IIRC odd releases are considered not stable and support is dropped in a month or so after even is out.

[SimenB]

I think we should wait until it's EOL. June 2018 according to https://github.com/nodejs/Release/blob/master/README.md

[thymikee]

Speaking of EOL, today is the day for Node 4 ❤️

[SimenB]

@cpojer Thoughts on this, and maybe removing node 9?

[cpojer]

Yep, let’s drop 4 for real and 9 too.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.