Add test for "beforeEach" in "test" behavior

[mjesun]

#6006 didn't fix the issue introduced in #5885, discussed in #5964. I'm adding a test (that will fail) until fixed.

[mjesun]

cc / @niieani

[niieani]

@mjesun does this mean FB's internal test suite is still broken?

[mjesun]

Yes :'( I thought I tested it, but can't see where I commented

[niieani]

Fix in #6100

[mjesun]

@niieani Now that the test is in master, could you bring back #5885, #6006 and #6100 altogether, without the legacy flag? Having this would be perfect and then I'm happy to merge it again. Sorry for all the churn I've created, I'm not happy with it either 😔

[SimenB]

@mjesun this test should either be fixed or skipped on windows, appveyor is broken

[mjesun]

@SimenB looks like this PR passed on AppVeyor: https://ci.appveyor.com/project/Daniel15/jest/build/7913

[SimenB]

That's odd, the merge failed: https://ci.appveyor.com/project/Daniel15/jest/build/7914

[niieani]

@mjesun revert the revert (lol) #6105 and merge #6100 on top and it should be golden.

[mjesun]

@niieani can you remove the legacy flag on #6100?

[SimenB]

It's not a flag though, it's config. Why is it an issue adding that to package.json in FB?

[niieani]

@mjesun Given @SimenB's comment on unintuitive ordering here #6105 (comment) can we confirm that we do not want this odd behavior behind a flag in config?

[mjesun]

If we can figure out someone who will clean this internally, I'm happy having the flag // cc @cpojer

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.