Add descriptive message for 'unexpected token' errors #6275
Conversation
| expect(stdout).toBe(''); | ||
| expect(stderr).toMatch(/Jest encountered an unexpected token/); | ||
| expect(stderr).toMatch(/import {module}/); | ||
| expect(stderr).toMatch(/Unexpected token import/); |
There was a problem hiding this comment.
would it make sense to exatrct the whole thing and snapshot it? Just to make sure formatting doesn't get messed up accidentally
There was a problem hiding this comment.
I think we're good with not snapshotting it, copy and indentation changes will be clearly visible in the PR diff
| @@ -315,6 +316,36 @@ export default class ScriptTransformer { | |||
| e.stack = e.codeFrame; | |||
| } | |||
|
|
|||
| if ( | |||
There was a problem hiding this comment.
can we also take it outside of this module and make it more declarative? it makes it really bloated :)
like
if (
e instanceof SyntaxError &&
e.message.includes('Unexpected token') &&
!e.message.includes(' expected')
) {
e = addTransformErrorMessage(e);
}
SimenB
dismissed
their stale review
Wait no, CI failed on node 10 on your new test
packages/jest-runtime/src/helpers.js
Outdated
| e.stack = | ||
| `${chalk.bold.red('Jest encountered an unexpected token')} | ||
|
|
||
| This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not JavaScript. |
There was a problem hiding this comment.
Would it be more accurate to say this you are trying to import a file which node cannot parse?
packages/jest-runtime/src/helpers.js
Outdated
|
|
||
| If you need to read non-JS files (e.g. binary assets), stubbing them out with ${chalk.bold( | ||
| '"moduleNameMapper"', | ||
| )} should help. |
There was a problem hiding this comment.
How about:
Jest encountered an unexpected token
This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.
By default, if Jest sees a
.babelrc, it will use that to transform your files, ignoringnode_modules. To have some, of yournode_modulesfiles transformed, you can specify a custom "transformIgnorePatterns" in your config.If you need a custom transformation specify a "transform" option in your config.
If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.
|
Updated the test and the copy |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
We had a lot of issues with "unexpected token" errors. Time to actually throw something more descriptive :)
Attaching a screenshot (the part above
/Users/...is added with this PR):Pretty please check the language if we can make the message easier to comprehend 🙏
Test plan
Integration test