Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing regex util #6511

Closed
wants to merge 1 commit into from
Closed

Conversation

peteruithoven
Copy link

Should fix: #6385
Credits for fix go to @tshinnic

Should fix: jestjs#6385
Credits for fix go to @tshinnic
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Jun 22, 2018

Thanks! Mind adding a test which breaks without this change? We could add an assertion like expect(() => new RegExp(the regex)).not.toThrow() in the suite for jest-regex-util.

Although it seems the failing test is just fixed? Maybe just updating that assertion is the correct fix.

https://github.com/facebook/jest/blob/d1ce3cd0135b5a8b64f84998fd5f36be4afb2bef/packages/jest-regex-util/src/__tests__/index.test.js#L35-L40

@thymikee @seanpoulter thoughts?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest 23 --config breaks create-react-app on Windows
3 participants