-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docusaurus to 1.3.2 #6644
Conversation
Seeing as the api key is already in the URL when performing searches, I see no reason to not just have it in source. @cpojer @thymikee @rickhanlonii thoughts on that? |
If you notice it in this PR preview, https://deploy-preview-6644--jest-preview.netlify.com/ now can search and previously it can't because previously process.env.ALGOLIA_JEST_API_KEY is not set in netlify We at Docusaurus expose it as well But I'll follow Jest team decision on this 👍 |
Loving the preview :D So good |
@SimenB even Docusaurus didn't search according to version 😭. @yangshun @JoelMarcey |
Codecov Report
@@ Coverage Diff @@
## master #6644 +/- ##
=======================================
Coverage 63.73% 63.73%
=======================================
Files 235 235
Lines 8935 8935
Branches 4 3 -1
=======================================
Hits 5695 5695
Misses 3239 3239
Partials 1 1 Continue to review full report at Codecov.
|
As @SimenB already mentioned, this API key doesn't look like a secret, so I'm ok exposing it. |
In addition, I think we can close all the 404 jest website error. I've been monitoring the website for few days and there is no 404 so far. This version also includes a non-zero exit code for any build error (facebook/docusaurus#809) so the 404 won't happen easily. Let us know if it does happen though. Will come running to fix it 😎 |
We haven't had a merge spree either, but I agree we could close them as hopefully fixed. Easy enough to reopen or file new ones |
I'm quite confident that at least the website going down won't happen easily. Few reasons:
Nevertheless, we all hope it won't happen 😍 |
Is it possible to add the ALGOLIA_JEST_API_KEY key to a Netlify config? |
@rickhanlonii |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Consider this commit endiliey/endiliey.github.io@4c6abe0
Now the deploy commit on
gh-pages
shows the correct triggering commitendiliey/endiliey.github.io@936bbc3
Make debugging life easier 👍
(refer to test plan below)
cc @yangshun @JoelMarcey
Test plan
Search according to current version.
Example I'm at 22.2, my search will be scoped to 22.2 docs.
Example I'm at docs/en/next, my search will be scoped to docs/en/next docs.