-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Explain how to rewrite assertions to avoid large irrelevant diff #6971
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ea18c26
docs: Explain how to rewrite assertions to avoid large irrelevant diff
pedrottimark 9c892cc
Update CHANGELOG.md
pedrottimark bcb4ec8
Fix pretty lint error
pedrottimark 6119713
Merge branch 'master' into explain-diff
pedrottimark 09e17a2
Fix pretty lint error in CONTRIBUTING.md
pedrottimark 88b1e58
Revert "Fix pretty lint error in CONTRIBUTING.md"
SimenB 3f09a3d
Merge branch 'master' into explain-diff
SimenB 8b19210
Copy explanation to version-23.6 doc
pedrottimark fd1e505
Copy explanation to earlier versioned docs
pedrottimark 3449f0c
fix lint
SimenB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrottimark did you mean for these to be on separate paragraphs? If so, there has to be 2 newlines, as MD collapses them (to allow you to write e.g. max 80 chars wide, but still render as a single paragraph without any weird newlines)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my bad. Do you want to push a commit or have me submit follow up pull request to provide missing blank lines.
Also, notice duplicate
Chore & Maintenance
heading inCHANGELOG.md
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to fix and just push to master 🙂