Standardize file names in packages/jest-resolve #7292
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
packages/jest-resolve/src/index.js
Outdated
| import defaultResolver from './default_resolver.js'; | ||
| import nodeModulesPaths from './nodeModulesPaths'; | ||
| import isBuiltinModule from './isBuiltinModule'; | ||
| import defaultResolver from './defaultResolver.js'; |
There was a problem hiding this comment.
we can remove the .js extension :)
There was a problem hiding this comment.
@thymikee Not able to understand why test failed
There was a problem hiding this comment.
We have an e2e suite where default_resolver is still used:
https://github.com/facebook/jest/blob/a91ea0ea2b62ecd272382de1496ade636160d7c8/e2e/custom-resolver/resolver.js#L3-L5
Change the file path and it should be good to go
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@thymikee Done, next? |
|
pick whatever suits you and let me know in the comment :) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This is part of #4969 - standardizes file names in packages/jest-resolve under Facebook naming conventions
Test plan
Did a manual verification, Tried running yarn test but got failure event on main