Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue4969: Standardize filenames: jest-runner pkg #7464

Merged
merged 6 commits into from
Dec 7, 2018
Merged

Issue4969: Standardize filenames: jest-runner pkg #7464

merged 6 commits into from
Dec 7, 2018

Conversation

betalantz
Copy link
Contributor

Summary

This PR standardizes the filenames in the jest-runner package as specified in Issue #4969

Test plan

No new test were written. Package passes existing tests.

thymikee
thymikee reviewed Dec 4, 2018
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind updating the test_runner.test.js as well? :) and update the changelog? there's shared entry for standardizing filenames

@betalantz
Copy link
Contributor Author

betalantz commented Dec 4, 2018 •
edited
Loading

@thymikee I wasn't sure how to update the CHANGELOG until after I had created the PR so that I'd have the PR # to add to the Changelog. So then I updated the Changelog on my local branch and pushed it up. Is that the correct process?

Regarding test_runner.test.js I just was unsure of that one. So it should be testRunner.test.js?

@thymikee
Copy link
Collaborator

thymikee commented Dec 4, 2018

Looks like you have older master locally. Can you rebase/merge with this repo master (test failures should be gone once you do it) and update the changelog accordingly?

@betalantz
Copy link
Contributor Author

It looks like I successfully resolved the issue (sorry, my git foo is not yet strong). I'll move on to jest-runtime and jest-snapshot

@thymikee thymikee mentioned this pull request Dec 6, 2018
Merged
thymikee
thymikee reviewed Dec 6, 2018
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase and adjust changleog so it fits into generic point where we gather all file renames? It's tagged with [*]

@codecov-io
Copy link

Codecov Report

Merging #7464 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7464   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files         247      247           
  Lines        9502     9502           
  Branches        5        5           
=======================================
  Hits         6381     6381           
  Misses       3119     3119           
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-runner/src/runTest.js 3.07% <ø> (ø)
packages/jest-runner/src/testWorker.js 0% <0%> (ø)
packages/jest-runner/src/index.js 75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2237d...b09324b. Read the comment docs.

thymikee
thymikee approved these changes Dec 6, 2018
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for cooperation 🙂

CHANGELOG.md Show resolved Hide resolved
@thymikee thymikee merged commit 509272d into jestjs:master Dec 7, 2018
thymikee added a commit to spion/jest that referenced this pull request Dec 18, 2018
@thymikee
Merge branch 'master' into pr/6871
0a4ae67 
* master: (24 commits)
  Add `jest.isolateModules` for scoped module initialization (jestjs#6701)
  Migrate to Babel 7 (jestjs#7016)
  docs: changed "Great Scott!" link (jestjs#7524)
  Use reduce instead of filter+map in dependency_resolver (jestjs#7522)
  Update Configuration.md (jestjs#7455)
  Support dashed args (jestjs#7497)
  Allow % based configuration of max workers (jestjs#7494)
  chore: Standardize filenames: jest-runner pkg (jestjs#7464)
  allow `bail` setting to control when to bail out of a failing test run (jestjs#7335)
  Add issue template labels (jestjs#7470)
  chore: standardize filenames in e2e/babel-plugin-jest-hoist (jestjs#7467)
  Add node worker-thread support to jest-worker (jestjs#7408)
  Add `testPathIgnorePatterns` to CLI documentation (jestjs#7440)
  pretty-format: Omit non-enumerable symbol properties (jestjs#7448)
  Add Jest Architecture overview to docs. (jestjs#7449)
  chore: run appveyor tests on node 10
  chore: fix failures e2e test for node 8 (jestjs#7446)
  chore: update docusaurus to v1.6.0 (jestjs#7445)
  Enhancement/expect-to-be-close-to-with-infinity (jestjs#7444)
  Update CHANGELOG formatting (jestjs#7429)
  ...
willsmythe pushed a commit to willsmythe/jest that referenced this pull request Dec 20, 2018
@betalantz @willsmythe
chore: Standardize filenames: jest-runner pkg (jestjs#7464)
3b47ac4 
* renamed 'run_test.js' to 'runTest.js' and updated imports

* renamed 'test_worker.js' to 'testWorker.js' and updated imports

* added PR to CHANGELOG

* renamed test_runner.test.js to testRunner.test.js

* Consolidated this PR to generic point with other file renames
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@betalantz @captain-yossarian
chore: Standardize filenames: jest-runner pkg (jestjs#7464)
63085c2 
* renamed 'run_test.js' to 'runTest.js' and updated imports

* renamed 'test_worker.js' to 'testWorker.js' and updated imports

* added PR to CHANGELOG

* renamed test_runner.test.js to testRunner.test.js

* Consolidated this PR to generic point with other file renames
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betalantz @thymikee @codecov-io @facebook-github-bot