chore: remove regenerator runtime completely #7599
Conversation
| const exportedModules = new Map([ | ||
| ['foo', 'foo'], | ||
| ['bar', 'bar'], | ||
| ['regenerator-runtime/runtime', 'fakeRegenerator'], |
There was a problem hiding this comment.
fakeRegenerator can be removed now
There was a problem hiding this comment.
This was more of a PoC (and I'm too lazy to run the tests on multiple nodes, so opened this up so CI could run), we should close this and go for yours 🙂
| @@ -3,9 +3,7 @@ | |||
| "version": "0.0.0", | |||
| "name": "example-async", | |||
| "devDependencies": { | |||
| "@babel/plugin-transform-runtime": "*", | |||
There was a problem hiding this comment.
this plugins is still used by the example, probably works because our deps have this plugins somewhere
There was a problem hiding this comment.
should remove it from the babel config, preset-env should be enough
There was a problem hiding this comment.
it then reports that regeneratorRuntime is not defined 🤔
There was a problem hiding this comment.
nvm that was because of the target missing
|
Intermittent node 8 failure, but since both node 6 and node 10 passed I'll call this a success. But let's land #7595 instead 🙂 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Alternative to #7595
Test plan
Green CI?