Revert ESM exports #7602
Merged
Revert ESM exports #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimenB it makes me sad that it makes you sad ;) |
|
Rollup is able to write default export to |
|
We use Babel, but we could use https://github.com/59naga/babel-plugin-add-module-exports. Rollup is used for the browser builds, though |
|
It can be used to bundle all package files too. It will probably speed up startup time which is quite long now. It takes around 3-4 seconds on my macbook air. Sometimes more. |
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts #7548, which converted all exports to ESM. That change makes Jest more verbose to use for CommonJS users (requiring
.defaultin most cases) and breaks the use of some of its packages (e.g.:jest-phabricator) out of the box, while not providing much additional value. We should revisit this once ESM has settled in Node (and also implemented support for ESM in modules specified in the config).Test plan
Unit, integration and e2e tests have been updated as well.