Added compact print option for default reporter

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ### Features
 
+- `[jest-cli]`: Add `compact` option to default reporter ([#7845](https://github.com/facebook/jest/pull/7845))
+
 ### Fixes
 
 - `[jest-cli]` Refactor `-o` and `--coverage` combined ([#7611](https://github.com/facebook/jest/pull/7611))

e2e/__tests__/__snapshots__/defaultReporter.test.js.snap

@@ -0,0 +1,10 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`default reporter prints compact message 1`] = `""`;
+
+exports[`default reporter prints compact message 2`] = `
+"FAIL __tests__/fail.test.js
+  ● failing tests › fails __tests__/fail.test.js:13:11
+  ● failing tests › fails 2 __tests__/fail.test.js:17:11
+  ● failing tests › fails 3 __tests__/fail.test.js:23:11"
+`;

e2e/__tests__/defaultReporter.test.js

@@ -0,0 +1,22 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow
+ */
+import {extractSummary} from '../Utils';
+import runJest from '../runJest';
+
+test('default reporter prints compact message', () => {
+  const {stdout, stderr} = runJest('default-reporter', [
+    '--verbose=false',
+    '--config',
+    JSON.stringify({
+      reporters: [['default', {compact: true}]],
+    }),
+  ]);
+  expect(stdout).toMatchSnapshot();
+  expect(extractSummary(stderr).rest).toMatchSnapshot();
+});

e2e/default-reporter/__tests__/fail.test.js

@@ -0,0 +1,27 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ */
+
+'use strict';
+
+describe('failing tests', () => {
+  it('fails', () => {
+    throw new Error(`failing test`);
+  });
+
+  it('fails 2', () => {
+    throw new Error(`failing test`);
+  });
+
+  it('passes', () => {});
+
+  it('fails 3', () => {
+    throw new Error(`failing test`);
+  });
+
+  it('passes 2', () => {});
+});

e2e/default-reporter/package.json

@@ -0,0 +1,3 @@
+{
+
+}

packages/jest-cli/src/TestScheduler.js

@@ -289,8 +289,14 @@ export default class TestScheduler {
   _setupDefaultReporters(collectCoverage: boolean) {
     this.addReporter(
       this._globalConfig.verbose
-        ? new VerboseReporter(this._globalConfig)
-        : new DefaultReporter(this._globalConfig),
+        ? new VerboseReporter(
+            this._globalConfig,
+            this._getReporterOption('verbose'),
+          )
+        : new DefaultReporter(
+            this._globalConfig,
+            this._getReporterOption('default'),
+          ),
     );
 
     if (collectCoverage) {
@@ -364,6 +370,14 @@ export default class TestScheduler {
     }
     return Promise.resolve();
   }
+
+  _getReporterOption(reporterName: string): Object {
+    const reporters = this._globalConfig.reporters || [];
+    const config = reporters.find(
+      item => Array.isArray(item) && item[0] === reporterName,
+    );
+    return (config && config[1]) || {};
+  }
 }
 
 const createAggregatedResults = (numTotalTestSuites: number) => {

packages/jest-cli/src/reporters/default_reporter.js

@@ -9,34 +9,43 @@
 
 /* global stream$Writable, tty$WriteStream */
 
-import type {AggregatedResult, TestResult} from 'types/TestResult';
+import type {
+  AggregatedResult,
+  AssertionResult,
+  TestResult,
+} from 'types/TestResult';
 import type {GlobalConfig, Path, ProjectConfig} from 'types/Config';
 import type {Test} from 'types/TestRunner';
 import type {ReporterOnStartOptions} from 'types/Reporters';
 
 import {clearLine, getConsoleOutput, isInteractive} from 'jest-util';
+import {formatFullTitle, TITLE_INDENT, TITLE_BULLET} from 'jest-message-util';
 import chalk from 'chalk';
 import BaseReporter from './base_reporter';
 import Status from './Status';
 import getResultHeader from './get_result_header';
 import getSnapshotStatus from './get_snapshot_status';
+import {formatTestPath, getLocation} from './utils';
 
 type write = (chunk: string, enc?: any, cb?: () => void) => boolean;
 type FlushBufferedOutput = () => void;
-
-const TITLE_BULLET = chalk.bold('\u25cf ');
+export type DefaultReporterOptions = {
+  compact: boolean,
+};
 
 export default class DefaultReporter extends BaseReporter {
   _clear: string; // ANSI clear sequence for the last printed status
   _err: write;
   _globalConfig: GlobalConfig;
+  _options: DefaultReporterOptions;
   _out: write;
   _status: Status;
   _bufferedOutput: Set<FlushBufferedOutput>;
 
-  constructor(globalConfig: GlobalConfig) {
+  constructor(globalConfig: GlobalConfig, options: ?DefaultReporterOptions) {
     super();
     this._globalConfig = globalConfig;
+    this._options = options || {};
     this._clear = '';
     this._out = process.stdout.write.bind(process.stdout);
     this._err = process.stderr.write.bind(process.stderr);
@@ -158,11 +167,19 @@ export default class DefaultReporter extends BaseReporter {
         test.context.config,
         testResult,
       );
-      this.printTestFileFailureMessage(
-        testResult.testFilePath,
-        test.context.config,
-        testResult,
-      );
+      if (this._options.compact) {
+        this.printCompactFailureMessage(
+          testResult.testFilePath,
+          test.context.config,
+          testResult,
+        );
+      } else {
+        this.printTestFileFailureMessage(
+          testResult.testFilePath,
+          test.context.config,
+          testResult,
+        );
+      }
     }
     this.forceFlushBufferedOutput();
   }
@@ -184,7 +201,7 @@ export default class DefaultReporter extends BaseReporter {
     const consoleBuffer = result.console;
     if (consoleBuffer && consoleBuffer.length) {
       this.log(
-        '  ' +
+        TITLE_INDENT +
           TITLE_BULLET +
           'Console\n\n' +
           getConsoleOutput(
@@ -208,4 +225,25 @@ export default class DefaultReporter extends BaseReporter {
     const snapshotStatuses = getSnapshotStatus(result.snapshot, didUpdate);
     snapshotStatuses.forEach(this.log);
   }
+
+  printCompactFailureMessage(
+    testPath: Path,
+    config: ProjectConfig,
+    result: TestResult,
+  ) {
+    result.testResults.forEach((assertionResult: AssertionResult) => {
+      if (assertionResult.failureMessages.length) {
+        const location = getLocation(assertionResult);
+        const path = formatTestPath(
+          config ? config : this._globalConfig,
+          result.testFilePath,
+        );
+        const fullTitle = formatFullTitle(assertionResult);
+        const fullPath = `${path}:${location.line}:${location.column}`;
+        this.log(
+          TITLE_INDENT + chalk.red(TITLE_BULLET + fullTitle) + ' ' + fullPath,
+        );
+      }
+    });
+  }
 }

packages/jest-cli/src/reporters/utils.js

@@ -8,7 +8,7 @@
  */
 
 import type {Path, ProjectConfig, GlobalConfig} from 'types/Config';
-import type {AggregatedResult} from 'types/TestResult';
+import type {AggregatedResult, AssertionResult} from 'types/TestResult';
 
 import path from 'path';
 import chalk from 'chalk';
@@ -273,3 +273,14 @@ export const wrapAnsiString = (string: string, terminalWidth: number) => {
     )
     .join('\n');
 };
+
+export const getLocation = (assertionResult: AssertionResult) => {
+  if (assertionResult.location) {
+    return assertionResult.location;
+  }
+  const matches = assertionResult.failureMessages[0].match(/(\d+):(\d+)/) || [];
+  return {
+    column: matches[2],
+    line: matches[1],
+  };
+};

packages/jest-cli/src/reporters/verbose_reporter.js

@@ -19,14 +19,15 @@ import type {Test} from 'types/TestRunner';
 import chalk from 'chalk';
 import {specialChars} from 'jest-util';
 import DefaultReporter from './default_reporter';
+import type {DefaultReporterOptions} from './default_reporter';
 
 const {ICONS} = specialChars;
 
 export default class VerboseReporter extends DefaultReporter {
   _globalConfig: GlobalConfig;
 
-  constructor(globalConfig: GlobalConfig) {
-    super(globalConfig);
+  constructor(globalConfig: GlobalConfig, options: DefaultReporterOptions) {
+    super(globalConfig, options);
     this._globalConfig = globalConfig;
   }
 

packages/jest-message-util/src/index.ts

@@ -52,11 +52,11 @@ const ANONYMOUS_FN_IGNORE = /^\s+at <anonymous>.*$/;
 const ANONYMOUS_PROMISE_IGNORE = /^\s+at (new )?Promise \(<anonymous>\).*$/;
 const ANONYMOUS_GENERATOR_IGNORE = /^\s+at Generator.next \(<anonymous>\).*$/;
 const NATIVE_NEXT_IGNORE = /^\s+at next \(native\).*$/;
-const TITLE_INDENT = '  ';
+export const TITLE_INDENT = '  ';
 const MESSAGE_INDENT = '    ';
 const STACK_INDENT = '      ';
 const ANCESTRY_SEPARATOR = ' \u203A ';
-const TITLE_BULLET = chalk.bold('\u25cf ');
+export const TITLE_BULLET = chalk.bold('\u25cf ');
 const STACK_TRACE_COLOR = chalk.dim;
 const STACK_PATH_REGEXP = /\s*at.*\(?(\:\d*\:\d*|native)\)?/;
 const EXEC_ERROR_MESSAGE = 'Test suite failed to run';
@@ -319,13 +319,8 @@ export const formatResultsErrors = (
       message = indentAllLines(message, MESSAGE_INDENT);
 
       const title =
-        chalk.bold.red(
-          TITLE_INDENT +
-            TITLE_BULLET +
-            result.ancestorTitles.join(ANCESTRY_SEPARATOR) +
-            (result.ancestorTitles.length ? ANCESTRY_SEPARATOR : '') +
-            result.title,
-        ) + '\n';
+        chalk.bold.red(TITLE_INDENT + TITLE_BULLET + formatFullTitle(result)) +
+        '\n';
 
       return title + '\n' + message + '\n' + stack;
     })
@@ -355,3 +350,8 @@ export const separateMessageFromStack = (content: string) => {
   const stack = messageMatch[2];
   return {message, stack};
 };
+
+export const formatFullTitle = (result: AssertionResult) =>
+  result.ancestorTitles.join(ANCESTRY_SEPARATOR) +
+  (result.ancestorTitles.length ? ANCESTRY_SEPARATOR : '') +
+  result.title;