expect: Improve report when matcher fails, part 7 #7866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For 4 matchers which correspond to
>
,>=
,<
,<=
number comparison operators:not
and operator followingExpected:
labelFor more information, see discussion with @jeysal in #7795
For these matchers which define expected intervals, I have not thought of any additional way to reduce apparent weirdness when received value is equal to expected boundary.
Residue for future pull request, in call to
ensureNumbers
helper function:options
as argument to displaypromise
andisNot
Test plan
Updated 66 snapshots. To save mental effort, review as 33 adjacent pairs of snapshots.
toBeGreaterThan
toBeGreaterThanOrEqual
toBeLessThan
toBeLessThanOrEqual
Here are pictures for 2 out of 4 matchers: