more precise circus asyncError types #8150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some circus events that we attach
asyncError
s to ourselves inindex.ts
, we actually know that we're not going to attach something that's not anError
, so we can be more precise thanException
(which is an alias ofany
). Events that getasyncError
s thrown by user code keepasyncError: Exception
(any
).This e.g. types the
.message =
in https://github.com/facebook/jest/blob/b97ac394ae4b1b5b8b8b69eb1d7b373642746c02/packages/jest-circus/src/eventHandler.ts#L46correctly instead of just allowing it because of
any
Test plan