chore: types #8430
Closed
chore: types #8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types of its arguments
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: CLOSING THIS PR, WILL OPEN MULTIPLE SMALLER PRS
Summary
Originally I began adjusting a few typing's that were marked
TODO, and then it began to have a bigger ripple than i anticipated, so i choked it back some and will to have push out the others in the future.I did first began updating typescript to 3.4.5 and building, and got new errors
implicitly has an 'any' typeas if "strict=true" wasn't really working in 3.4.1? So I left 3.4.5, and began from there.One of the bigger commits was within jest-config(normalize), where the original type casting made it difficult to confirm the actual type and had if blocks for
nevertypes, therefore the changes I made, enforce correct assignments based onAllOptions, and will throw if oldOptions has any unhandled non-matching keys toAllOptionsMay have conflicts/overlaps with: #8372 (needed to bump leven ), #8311 (normalize & types), #8410 (maxworkers prob safe here)
Test plan
some jest-config tests don't work on my local (windows), but not too sure if they work on master, will see what ci comes up with.