Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to eslint@6 #8855

Merged
merged 2 commits into from
Aug 20, 2019
Merged

chore: upgrade to eslint@6 #8855

merged 2 commits into from
Aug 20, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 19, 2019

Summary

Seems to have some weird lint errors, so a separate PR seems like a good idea.

image

file is definetely used, not sure what's up

EDIT: Seems to be a bug in babel-eslint
babel/babel-eslint#791
eslint/eslint#12117

I've locked it at 6.1 which works fine

Test plan

Green CI

@codecov-io
Copy link

Codecov Report

Merging #8855 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            next   #8855   +/-   ##
=====================================
  Coverage   63.8%   63.8%           
=====================================
  Files        274     274           
  Lines      11576   11576           
  Branches    2841    2842    +1     
=====================================
  Hits        7386    7386           
  Misses      3560    3560           
  Partials     630     630
Impacted Files Coverage Δ
packages/jest-environment-node/src/index.ts 48.48% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9336e74...7475ea1. Read the comment docs.

@SimenB SimenB merged commit 9288b93 into jestjs:next Aug 20, 2019
@SimenB SimenB deleted the eslint-6 branch August 20, 2019 08:28
SimenB added a commit that referenced this pull request Aug 21, 2019
SimenB added a commit that referenced this pull request Aug 22, 2019
SimenB added a commit that referenced this pull request Aug 22, 2019
@thymikee
Copy link
Collaborator

@SimenB seems like babel-eslint issue is resolved? https://twitter.com/left_pad/status/1165738603755925504

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants