-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create @jest/config-utils package #9403
Conversation
@@ -5,7 +5,8 @@ | |||
* LICENSE file in the root directory of this source tree. | |||
* | |||
*/ | |||
import {Config} from '@jest/types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the fix for #8570
Doesn't it make sense to create |
The reason I did it this way is so people can reuse some of the helpers without pulling in the massive |
Ah I see, we have somewhat similar situation in |
I wondered about creating a |
Let's circle back later |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Not too happy about the name. Main idea is to colocate both types and utils, since
jest-config
depends on the world to be able to resolve default dependencies in a pnp context.This makes it so only
jest-circus
,jest-jasmine
,jest-each
andjest-environment*
depends on@jest/types
.Fixes #8570
Test plan
Green CI