feat: override module.createRequire

packages/jest-runtime/src/__tests__/runtime_require_module.test.js

@@ -364,21 +364,54 @@ describe('Runtime requireModule', () => {
           expect(customRequire('./create_require_module').foo).toBe('foo');
         }
 
-        // createRequire with URL
+        // createRequire with URL object
         {
           const customRequire = exports.createRequire(
             pathToFileURL(runtime.__mockRootPath),
           );
           expect(customRequire('./create_require_module').foo).toBe('foo');
         }
 
+        // createRequire with file URL string
+        {
+          const customRequire = exports.createRequire(
+            pathToFileURL(runtime.__mockRootPath).toString(),
+          );
+          expect(customRequire('./create_require_module').foo).toBe('foo');
+        }
+
+        // createRequire with absolute module path
+        {
+          const customRequire = exports.createRequire(runtime.__mockRootPath);
+          expect(customRequire('./create_require_module').foo).toBe('foo');
+        }
+
+        // createRequire with relative module path
+        expect(() => exports.createRequireFromPath('./relative/path')).toThrow(
+          new TypeError(
+            `[ERR_INVALID_ARG_VALUE] The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received './relative/path'`,
+          ),
+        );
+
+        // createRequireFromPath with absolute module path
         {
           const customRequire = exports.createRequireFromPath(
             runtime.__mockRootPath,
           );
           expect(customRequire('./create_require_module').foo).toBe('foo');
         }
 
+        // createRequireFromPath with file URL object
+        expect(() =>
+          exports.createRequireFromPath(pathToFileURL(runtime.__mockRootPath)),
+        ).toThrow(
+          new TypeError(
+            `[ERR_INVALID_ARG_VALUE] The argument 'filename' must be string. Received '${pathToFileURL(
+              runtime.__mockRootPath,
+            )}'. Use createRequire for URL filename.`,
+          ),
+        );
+
         expect(exports.syncBuiltinESMExports).not.toThrow();
         expect(exports.builtinModules).toEqual(builtinModules);
       }));

packages/jest-runtime/src/index.ts

@@ -892,9 +892,17 @@ class Runtime {
       const createRequire = (modulePath: string | URL) => {
         const filename =
           typeof modulePath === 'string'
-            ? modulePath
+            ? modulePath.startsWith('file:///')
+              ? fileURLToPath(new URL(modulePath))
+              : modulePath
             : fileURLToPath(modulePath);
 
+        if (!path.isAbsolute(filename)) {
+          throw new TypeError(
+            `[ERR_INVALID_ARG_VALUE] The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received '${filename}'`,
+          );
+        }
+
         return this._createRequireImplementation({
           children: [],
           exports: {},
@@ -904,24 +912,32 @@ class Runtime {
         });
       };
 
-      const overriddenModule = {...nativeModule};
+      const overriddenModules: Partial<typeof nativeModule> = {};
 
       if ('createRequire' in nativeModule) {
-        Object.defineProperty(overriddenModule, 'createRequire', {
-          value: createRequire,
-        });
+        overriddenModules.createRequire = createRequire;
       }
       if ('createRequireFromPath' in nativeModule) {
-        Object.defineProperty(overriddenModule, 'createRequireFromPath', {
-          value: (filename: string) => createRequire(filename),
-        });
+        overriddenModules.createRequireFromPath = (filename: string | URL) => {
+          if (typeof filename !== 'string') {
+            throw new TypeError(
+              `[ERR_INVALID_ARG_VALUE] The argument 'filename' must be string. Received '${filename}'.${
+                filename instanceof URL
+                  ? ' Use createRequire for URL filename.'
+                  : ''
+              }`,
+            );
+          }
+          return createRequire(filename);
+        };
       }
       if ('syncBuiltinESMExports' in nativeModule) {
-        Object.defineProperty(overriddenModule, 'syncBuiltinESMExports', {
-          value: () => {},
-        });
+        overriddenModules.syncBuiltinESMExports = () => {};
       }
-      return overriddenModule;
+
+      return Object.keys(overriddenModules).length > 0
+        ? {...nativeModule, ...overriddenModules}
+        : nativeModule;
     }
 
     return require(moduleName);

yarn.lock

@@ -2164,7 +2164,12 @@
   dependencies:
     "@types/node" "*"
 
-"@types/node@*", "@types/node@>= 8":
+"@types/node@*":
+  version "13.7.0"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-13.7.0.tgz#b417deda18cf8400f278733499ad5547ed1abec4"
+  integrity sha512-GnZbirvmqZUzMgkFn70c74OQpTTUcCzlhQliTzYjQMqg+hVKcDnxdL19Ne3UdYzdMA/+W3eb646FWn/ZaT1NfQ==
+
+"@types/node@>= 8":
   version "13.1.8"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-13.1.8.tgz#1d590429fe8187a02707720ecf38a6fe46ce294b"
   integrity sha512-6XzyyNM9EKQW4HKuzbo/CkOIjn/evtCmsU+MUM1xDfJ+3/rNjBttM1NgN7AOQvN6tP1Sl1D1PIKMreTArnxM9A==