Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies and land changes for yarn berry #9545

Merged
merged 9 commits into from
Feb 10, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 9, 2020

Summary

These changes are enough for TSC to pass with yarn berry. Landing separately to keep that diff clean (also, this is more correct).

We might consider optional peer deps here for the @types/node stuff. Not sure

Test plan

Green CI

@SimenB SimenB changed the title chore: refresh lockfile chore: land changes for yarn berry Feb 9, 2020
@SimenB SimenB force-pushed the refresh-yarn-lock branch from e0add3f to 1db89ce Compare February 9, 2020 22:31
@drew-gross

This comment has been minimized.

@SimenB SimenB changed the title chore: land changes for yarn berry chore: land changes for yarn berry and upgrade dependencies Feb 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #9545 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9545      +/-   ##
==========================================
- Coverage   65.06%   65.04%   -0.02%     
==========================================
  Files         283      286       +3     
  Lines       12121    12123       +2     
  Branches     3004     3004              
==========================================
- Hits         7886     7885       -1     
- Misses       3597     3600       +3     
  Partials      638      638
Impacted Files Coverage Δ
packages/jest-jasmine2/src/jasmine/Env.ts 0% <ø> (ø) ⬆️
packages/jest-runtime/src/index.ts 65.3% <ø> (ø) ⬆️
packages/jest-snapshot/src/inline_snapshots.ts 82% <ø> (-0.18%) ⬇️
e2e/babel-plugin-jest-hoist/__test_modules__/b.js 0% <0%> (ø)
...babel-plugin-jest-hoist/__test_modules__/Mocked.js 0% <0%> (ø)
e2e/babel-plugin-jest-hoist/__test_modules__/a.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1e98b...ee34d47. Read the comment docs.

@SimenB SimenB changed the title chore: land changes for yarn berry and upgrade dependencies chore: upgrade dependencies and land changes for yarn berry Feb 10, 2020
@SimenB SimenB merged commit 496f54a into jestjs:master Feb 10, 2020
@SimenB SimenB deleted the refresh-yarn-lock branch February 10, 2020 00:31
@SimenB SimenB mentioned this pull request Feb 10, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants