Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade chalk to v4 #9752

Merged
merged 4 commits into from
May 2, 2020
Merged

chore: upgrade chalk to v4 #9752

merged 4 commits into from
May 2, 2020

Conversation

AndrewLeedham
Copy link
Contributor

Summary

Chalk 4 removed the LevelEnum which caused a TS error when using --isolatedModules see: chalk/chalk#373

Test plan

Green CI

@facebook-github-bot
Copy link
Contributor

Hi @AndrewLeedham!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@AndrewLeedham
Copy link
Contributor Author

Seems chalk 4 drops compatibility with node < 10 :(

@SimenB
Copy link
Member

SimenB commented Apr 2, 2020

Yup, this'll have to wait for Jest 26. Would love to add isolatedModules to our own config at that point, chalk was the only blocker for us

@SimenB SimenB added this to the Jest 26 milestone Apr 2, 2020
cpojer
cpojer approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cpojer cpojer merged commit 6792ff2 into jestjs:master May 2, 2020
jeysal added a commit to jeysal/jest that referenced this pull request May 2, 2020
@jeysal
Merge remote-tracking branch 'upstream/master' into circus-add-test-w…
73b95bc 
…hile-running

* upstream/master: (331 commits)
  chore: update ts-eslint (jestjs#9953)
  Updated config docs with default transform value (jestjs#8583)
  Update jest-phabricator documentation (jestjs#8662)
  chore: remove dependency on `realpath-native` (jestjs#9952)
  chore: bump dated dependencies (jestjs#9951)
  chore: another try at fixing test-utils dependency
  chore: update lockfile due to beta release
  chore: move changelog entry and fix tets utils dependency
  Fix time duration formatting as per SI (jestjs#9765)
  v26.0.0-alpha.0
  chore: run some jsdom tests in leak check (jestjs#9938)
  chore: upgrade chalk to v4 (jestjs#9752)
  feat: upgrade to JSDOM 16 (jestjs#9606)
  chore: remove checks for compileFunction (jestjs#9949)
  chore: drop node 8 support  (jestjs#9423)
  Remove leftover `providesModuleNodeModules` (jestjs#9948)
  [BREAKING] Pojer -> Nakazawa
  chore: revert lockfile changes from 2b32fe6
  chore: move changelog entry and fix lint
  Remove `providesModuleNodeModules` from Jest. (jestjs#9583)
  ...
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@cpojer cpojer cpojer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Jest 26
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewLeedham @facebook-github-bot @SimenB @cpojer