chore: require minimum typescript@3.8 #9823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
remove-downlevel
branch
from
65ad387
to
2b55a34
Compare
|
Does jest have a minimum typescript version for jest 25 ? If yes, we would like to follow the same minimum version for ts-jest |
|
25 should work down to and including TS 3.4 |
SimenB
force-pushed
the
remove-downlevel
branch
from
2b55a34
to
3cebab1
Compare
SimenB
force-pushed
the
remove-downlevel
branch
from
3cebab1
to
fdbc943
Compare
Codecov Report
@@ Coverage Diff @@
## master #9823 +/- ##
=======================================
Coverage 64.89% 64.89%
=======================================
Files 289 289
Lines 12233 12233
Branches 3030 3032 +2
=======================================
Hits 7939 7939
Misses 3654 3654
Partials 640 640
Continue to review full report at Codecov.
|
2 tasks
1 task
8 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change, so need to wait for Jest 26. The version will probably be bumped to 3.9 or whatever is the latest at the time of our release
Test plan
🚀