fix: throw on nested test declarations #9828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Apr 16, 2020
| const {asyncError, fn, mode, testName: name, timeout} = event; | ||
|
|
||
| if (currentlyRunningTest) { |
There was a problem hiding this comment.
should probably add this to add_hook as well
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
|
Hmm, this breaks #5964. Might need to back out the hook part, and try to re-land later if FB has migrated their tests. EDIT: Yup, need to back that part out: |
|
Disallowing hooks is kept here: https://github.com/SimenB/jest/tree/disallow-hooks-in-tests for some point in the future when we can land it |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I love circus, so simple to fix 😀 I reused the error message from Jasmine as it made it easier to write a test for.
Fixes #9824
Fixes #9825
Test plan
E2E test added that passes for both jasmine and circus