Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run CircleCI on node 14 #9870

Merged
merged 1 commit into from
Apr 23, 2020
Merged

chore: run CircleCI on node 14 #9870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,20 @@ jobs:
- store_test_results:
path: reports/junit

test-node-14:
working_directory: ~/jest
docker:
- image: circleci/node:14
steps:
- checkout
- restore-cache: *restore-cache
- run: *install
- save-cache: *save-cache
- run:
command: yarn test-ci-partial
- store_test_results:
path: reports/junit

test-browser:
working_directory: ~/jest
docker:
Expand Down Expand Up @@ -123,7 +137,8 @@ workflows:
- test-node-8
- test-node-10
- test-node-12
- test-node-13 # current
- test-node-13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we get rid of 13 now then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not EOL until June. I'm thinking we drop it when we drop 8. We're always waiting for the windows and mac runs on CI anyways, so it doesn't slow us down to keep it

- test-node-14 # current
- test-jest-circus
- test-browser
- test-or-deploy-website:
Expand Down