Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NODE_PRESERVE_SYMLINKS and --preserve-symlinks behavior #9976

Closed
wants to merge 2 commits into from
Closed

Add support for NODE_PRESERVE_SYMLINKS and --preserve-symlinks behavior #9976

wants to merge 2 commits into from

Conversation

ganemone
Copy link

@ganemone ganemone commented May 5, 2020

Summary

This adds support for projects using jest with symlinked files via supporting both the NODE_PRESERVE_SYMLINKS environment variable and the --preserve-symlinks node flag.

Test plan

The PR includes integration tests.

@ganemone ganemone force-pushed the symlinks branch 2 times, most recently from 185664c to 198e330 Compare May 5, 2020 17:53
@thymikee
Copy link
Collaborator

thymikee commented May 5, 2020 •
edited
Loading

I assume #9732 can be closed now? Please do, if that's right

@ganemone ganemone mentioned this pull request May 6, 2020
Closed
@thymikee
Copy link
Collaborator

thymikee commented May 6, 2020

What about this one: #7364? It's a bit older but tackles the same problem space

@ganemone
Copy link
Author

ganemone commented May 6, 2020

@thymikee That PR is stale and was never finished but was attempting to do the same thing.

@thymikee thymikee requested a review from SimenB May 6, 2020 15:37
@ganemone ganemone force-pushed the symlinks branch 4 times, most recently from d1ca473 to ddfd51e Compare May 14, 2020 18:01
@ganemone
Copy link
Author

@thymikee / @SimenB could you take another look here?

@ganemone ganemone force-pushed the symlinks branch 2 times, most recently from 090c3cd to 8742741 Compare June 1, 2020 15:08
@SimenB SimenB mentioned this pull request Jun 4, 2020
Open
@ganemone
Copy link
Author

ganemone commented Jun 5, 2020

bump @SimenB / @thymikee - would really appreciate some movement on this. Thank you!

@ganemone
Copy link
Author

Pinging some other people to get some movement on this: @cpojer @pedrottimark

@ganemone
Copy link
Author

I understand these are tough times for everyone. If there is anything I can do to help move this along please let me know. Happy to add more tests, documentation, or discuss alternative approaches if you aren't happy with this approach. It would be really awesome to get this landed to unblock everyone trying to use jest with bazel.

@hotchpotch
Copy link

I hope this PR will also be merged.

@artola
Copy link
Contributor

artola commented Sep 29, 2020

@SimenB do you expect to get this merged anytime soon? (please 🙏 )

@nathanmarks
Copy link

nathanmarks commented Nov 3, 2020 •
edited
Loading

Any updates on this? @ganemone @SimenB ?

@mistic
Copy link

mistic commented Mar 16, 2021 •
edited
Loading

@SimenB can we move this PR forward? I think it makes total sense to respect the previously defined Node options or at least offer a default resolver config we can set just like webpack does 😃

@ganemone ganemone mentioned this pull request Mar 31, 2021
Merged
3 tasks
@pauldraper
Copy link

pauldraper commented Apr 12, 2021 •
edited
Loading

Thanks @ganemone for your work.

I'm sorry the Facebook/jest team doesn't seem to care to look at this very helpful contribution.

@mooh-code
Copy link

any updates?

@w-a-b
Copy link

w-a-b commented Jul 13, 2021

⌛

@missing1984
Copy link

missing1984 commented Oct 14, 2021 •
edited
Loading

Any updates on this? I found jest is the ONLY main stream tool that does not support this flag

@github-actions
Copy link

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 14, 2022
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this Nov 13, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB Awaiting requested review from SimenB

Assignees
No one assigned
Labels
cla signed Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.