feat: Add custom dns resolver #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mohitsethia
commented
Jul 13, 2024
| ID: "http", | ||
| RHost: RandomCaptivePortal, | ||
| } | ||
| httpProtocol.Probe = func(domain string, timeout time.Duration) (string, error) { |
There was a problem hiding this comment.
Kept it consistent for all Probes as a receiver method to Protocol.
|
@mohitsethia - thanks for implementing this. The current implementation of the DNS probe seemed a bit backward to me: it resolves a name using the local DNS server. While it may be a good indication if whether the local computer's connection is up, it's not necessarily a great indicator of whether the internet connection is for a site as the response may be cached. It would be more interesting to resolve a host with an external DNS server, which you've implemented. I make use of up in a tool of mine and have bumped into this issue: see hugoh/upd#26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the support of the custom DNS Resolver, reads with -r flag & would use the default one if not provided.
issue [link]