Port UnionConverter to STJ re #43 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaces Newtonsoft bits from scaffold with the actual STJ bits * Tries to retain symmetry with Newtonsoft UnionConverter impl
(Oh, they're all failing)
* Wrong namespace lol, and * It seems like boxing a DU means that STJ won't use the convert for serialization. Maybe this is something to do with derived types and JsonConverter dotnet/runtime#30427
…own discriminator and catch-all cases
bartelink
force-pushed
the
nickdarvey-unionconverter-stj
branch
from
5f42e3f
to
927271c
Compare
bartelink
force-pushed
the
nickdarvey-unionconverter-stj
branch
from
69ca5fc
to
2481fb6
Compare
|
Woohoo I found the problem/solution (some tidying and/or extending of test suite still to be done, but seems this is on track for finally being released) |
bartelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of the commits in this PR derive from #43 by @NickDarvey
In particular, the entire implementation and test suite was already complete, but was parked (and inadvertently closed, hence its in this PR).
The later commits effect minor cleanups:
#ifdefs to make clear the commonalities (and, most importantly, the minor differences) between theSystem.Text.JsonandNewtonsoft.Jsonimplementations wrt Pickling and JsonIsomorphismUnionConverterTeststo test the STJ and JNK variants with a common test suite