Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Equinox.Core module #164

Merged
merged 5 commits into from
Sep 27, 2019
Merged

Extract Equinox.Core module #164

merged 5 commits into from
Sep 27, 2019

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Sep 22, 2019 •
edited
Loading

Prompted by #161 and upcoming work on Equinox.SqlStreamStore, this splits shared store interfaces and helpers into an Equinox.Core module

@bartelink bartelink marked this pull request as ready for review September 22, 2019 20:07
@bartelink
Copy link
Collaborator Author

This cleans up stuff a lot; good call @Rajivhost. Open to naming, or any other kinds of suggestions @Rajivhost @DSilence

@bartelink
Copy link
Collaborator Author

🤔Given the nature of the various modules in Equinox.Storage (see https://github.com/jet/equinox/tree/extract-storage/src), I'm thinking renaming to Equinox.Core might be a better name, and would probably sort nicely alphabetically beside an Equinox.Cache (or Equinox.Cache.SystemRuntime) module.

@bartelink bartelink changed the title Extract Equinox.Storage module Extract Equinox.Core module Sep 23, 2019
@bartelink
Copy link
Collaborator Author

Rename to Equinox.Core completed

@bartelink
Copy link
Collaborator Author

I'll likely do #61 some time soon, ideally after #161 ;)
@DSilence see anything you'd like changed before this gets merged [with a merge-commit?] ?

@bartelink bartelink merged commit 8fb23c2 into master Sep 27, 2019
@bartelink bartelink mentioned this pull request Sep 29, 2019
Merged
@bartelink bartelink deleted the extract-storage branch October 5, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartelink