Simplify AsyncCacheCell #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Atm, a this does not achieve any particular behavior advantage, I have no plans to put this onto the 2.x release line and instead will leave it on master to be validated as part of the 3.x release series |
bartelink
force-pushed
the
simplify-cachecell
branch
from
15197cb
to
1dfa609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial impl of AsyncCacheCell passes the tests and fulfilled the need in the context that it was written (an initialization gating device in
Equinox.Cosmos)However the
PeekIsValidperf tweak is a messy ad-hoc thing, so as precursor to #228 I clarified and simplified the logic