Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ICache #389

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Remove ICache #389

merged 3 commits into from
Jun 5, 2023

Conversation

bartelink
Copy link
Collaborator

Spike - it could be this much shorter if we removed ICache ;) @DSilence

@bartelink bartelink changed the title Remove icache Remove ICache May 18, 2023
@bartelink bartelink mentioned this pull request May 18, 2023
4 tasks
Copy link
Contributor

@nordfjord nordfjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO 🚀

Jokes aside, I'm not aware of another implementation of ICache anywhere. At least not out in the open https://github.com/search?type=code&q=%22interface+ICache+with%22+language%3AF%23

@bartelink
Copy link
Collaborator Author

Yeah, @DSilence put it in for a reason though - the company he was working for was using another cache (which had Task interfaces which is why there was egregious Asyncness in the interface).
But it was the V3 rollover last time I asked him, so maybe he'll be all YOLO on it for V4 :D

@bartelink bartelink force-pushed the bounded-staleness branch 4 times, most recently from 2b6db63 to 2f90310 Compare May 19, 2023 12:10
@bartelink bartelink force-pushed the bounded-staleness branch 2 times, most recently from 79fa120 to 154a6f0 Compare May 25, 2023 09:28
@bartelink bartelink marked this pull request as ready for review June 3, 2023 00:40
@bartelink
Copy link
Collaborator Author

@DSilence Thinking I'll bite the bullet on this as it makes the code more legible and removes a concept - if the system in question is upgrading, we'll hopefully be able to work out a solution without impeding that (i.e. open to reintroducing at some point, but taking the lack of traffic here as assent!)

@bartelink bartelink force-pushed the remove-icache branch 2 times, most recently from ff87188 to a932e1a Compare June 5, 2023 08:56
Base automatically changed from bounded-staleness to master June 5, 2023 09:32
@bartelink bartelink force-pushed the remove-icache branch 2 times, most recently from 384386e to 3bb73d8 Compare June 5, 2023 09:48
@bartelink bartelink merged commit d3aea5b into master Jun 5, 2023
@bartelink bartelink deleted the remove-icache branch June 5, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants