-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ICache #389
Remove ICache #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOLO 🚀
Jokes aside, I'm not aware of another implementation of ICache anywhere. At least not out in the open https://github.com/search?type=code&q=%22interface+ICache+with%22+language%3AF%23
873daf0
to
a4d537d
Compare
Yeah, @DSilence put it in for a reason though - the company he was working for was using another cache (which had Task interfaces which is why there was egregious Asyncness in the interface). |
2b6db63
to
2f90310
Compare
79fa120
to
154a6f0
Compare
4c3c99f
to
9bdd317
Compare
@DSilence Thinking I'll bite the bullet on this as it makes the code more legible and removes a concept - if the system in question is upgrading, we'll hopefully be able to work out a solution without impeding that (i.e. open to reintroducing at some point, but taking the lack of traffic here as assent!) |
ff87188
to
a932e1a
Compare
384386e
to
3bb73d8
Compare
Spike - it could be this much shorter if we removed
ICache
;) @DSilence