fix(Cache): Correct concurrent request coalescing #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the condition for the swap, which has a race condition that can mean delivering the value we've just literally determined to be too old
Reduce a test timeout to hopefully reduce flakiness
Also fixes an oversight: even if a concurrent request was too old for the
maxAge
, it can still serve as the base state for an incremental load (not a big deal in the normal case; only the very first load would be suboptimal)