-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-event Batches #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, you've probably got these sorted already OOB but just in case...
@jinglegit for avoidance of doubt, I'm working on the JS atm, in line with comments above |
OK, I know lots more JS now; there are some NREs, presumably due to off by one errors. Also some of the tests are failing due to needing to be adjusted to fit the new representation (the test cases assume one event per item, and max batchSize events per Batch, which needs to be multiplied by the page size where one is in force etc) |
98a881b
to
da5d45f
Compare
8be11e9
to
39f0f24
Compare
3d966f1
to
d33749d
Compare
ef5eecc
to
d176146
Compare
377ee66
to
48da953
Compare
* Multi-event batches; Tip now a Batch too * Handle startIndex within multi-item batches
* Multi-event batches; Tip now a Batch too * Handle startIndex within multi-item batches
* Multi-event batches; Tip now a Batch too * Handle startIndex within multi-item batches
* Multi-event batches; Tip now a Batch too * Handle startIndex within multi-item batches
* Multi-event batches; Tip now a Batch too * Handle startIndex within multi-item batches
* Multi-event batches; Tip now a Batch too * Handle startIndex within multi-item batches
This PR moves the Access Strategy from it's present approach of having a special case "Index page" (which was arrived at as a spike impl of a performance improvement for the Favorites test) to a more uniform layout which achieves at least the following objectives
One key change herein is that we now have two indices (aside from
p
) -i
is joined byn
(which corresponds to thei
of the next batch (which, on the-1
/ Tip batch is theexpectedVersion
) - this does not seem to have affected insert costsNote while some query costs have gone up, as noted, the bulk of the tests triggering this are artificially inducing the very extra roundtrips and bandwidth that this change will ultimately reduce.