Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few small errors in the readme #50

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

Eschon
Copy link
Contributor

@Eschon Eschon commented Jul 2, 2020

I found and fixed a few small errors in the readme. I'm not 100% sure about the removing the strict: false but if I haven't missed anything it is not used in the code anywhere

@jetersen
Copy link
Owner

jetersen commented Jul 6, 2020

link to see current commit author: https://github.com/jetersen/express-ipfilter/pull/50/commits/194e4ecc026ba853023a9b56f6f421cfac57153c.patch

@Eschon
You might want to set up an email alias on your GitHub account 🥇
https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Or look into fixing your git user.email config 😅
https://help.github.com/articles/setting-your-commit-email-address-in-git
then you would need to amend your commits: https://stackoverflow.com/a/3042512
after changing author

to get proper credit for your commits 🏆

@Eschon
Copy link
Contributor Author

Eschon commented Jul 6, 2020

Thanks for the hint!
I've set up the alias.

@jetersen jetersen merged commit 7bc0ddf into jetersen:master Aug 12, 2020
@Eschon Eschon deleted the fix/readme branch August 13, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants