Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove devbox interface #1690

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

mikeland73
Copy link
Contributor

Summary

Removes the devbox interface (devbox.go in root). I feel like it was making code harder to follow and not providing any value.

Chatted with @loreto a few weeks ago about doing this. I was about to add a new function to interface and decided to remove instead.

A possible follow up could be to remove devopt.Opts to avoid some ducplication.

How was it tested?

builds, CICD.

@mikeland73 mikeland73 requested review from loreto and savil December 21, 2023 00:47
@mikeland73 mikeland73 merged commit d66f6ea into main Dec 21, 2023
24 checks passed
@mikeland73 mikeland73 deleted the landau/remove-devbox-interface branch December 21, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants